[gpfsug-discuss] =?utf-8?Q?=E2=80=94subblocks-per-full-block_?=in 5.0.1

[Barry Evans]

Slight wonkiness in mmcrfs script that spits this out —subblocks-per-full-block as an invalid option.

No worky:

    777         subblocks-per-full-block )
    778           if [[ -z $optArg ]]
    779           then
    780             # The expected argument is not in the same string as its
    781             # option name.  Get it from the next token.
    782             eval optArg="\${$OPTIND}"
    783             [[ -z $optArg ]] &&  \
    784               syntaxError "missingValue" $noUsageMsg "--$optName_lc"
    785             shift 1
    786           fi
    787           [[ -n $subblocksPerFullBlockOpt ]] &&  \
    788             syntaxError "multiple" $noUsageMsg "--$optName_lc"
    789           subblocksPerFullBlockOpt="--$optName_lc"
    790
    791           nSubblocksArg=$(checkIntRange --subblocks-per-full-block $optArg 32 8192)
    792           [[ $? -ne 0 ]] && syntaxError nomsg $noUsageMsg
    793           tscrfsParms="$tscrfsParms --subblocks-per-full-block $nSubblocksArg"
    794           ;;

Worky:


    777         subblocks-per-full-block )
    778           if [[ -z $optArg ]]
    779           then
    780             # The expected argument is not in the same string as its
    781             # option name.  Get it from the next token.
    782             eval optArg="\${$OPTIND}"
    783             [[ -z $optArg ]] &&  \
    784               syntaxError "missingValue" $noUsageMsg "--$optName_lc"
    785             shift 1
    786           fi
    787           #[[ -n $subblocksPerFullBlockOpt ]] &&  \
    788           [[ -n $nSubblocksArg  ]] &&  \
    789             syntaxError "multiple" $noUsageMsg "--$optName_lc"
    790           #subblocksPerFullBlockOpt="--$optName_lc"
    791           nSubblocksArg="--$optName_lc"
    792
    793           nSubblocksArg=$(checkIntRange --subblocks-per-full-block $optArg 32 8192)
    794           [[ $? -ne 0 ]] && syntaxError nomsg $noUsageMsg
    795           tscrfsParms="$tscrfsParms --subblocks-per-full-block $nSubblocksArg"
    796           ;;

Looks like someone got halfway through the variable change “subblocksPerFullBlockOpt" is referenced elsewhere in the script:

if [[ -z $forceOption ]]
then
  [[ -n $fflag ]] &&  \
    syntaxError "invalidOption" $usageMsg "$fflag"
  [[ -n $subblocksPerFullBlockOpt ]] &&  \
    syntaxError "invalidOption" $usageMsg "$subblocksPerFullBlockOpt"
fi

...so this is probably naughty on my behalf.



Kind Regards,
Barry Evans
CTO/Co-Founder
Pixit Media Ltd
+44 7950 666 248
bevans at pixitmedia.com



-- 
 <http://pixitmedia.com>
This email is confidential in that it is intended 
for the exclusive attention of the addressee(s) indicated. If you are not 
the intended recipient, this email should not be read or disclosed to any 
other person. Please notify the sender immediately and delete this email 
from your computer system. Any opinions expressed are not necessarily those 
of the company from which this email was sent and, whilst to the best of 
our knowledge no viruses or defects exist, no responsibility can be 
accepted for any loss or damage arising from its receipt or subsequent use 
of this email.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://gpfsug.org/pipermail/gpfsug-discuss_gpfsug.org/attachments/20180517/27596749/attachment-0001.htm>